Re: Missing comment for max_logical_replication_workers in postgresql.conf.sample

On Thu, 27 Jul 2017 14:38:29 +0900
Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:

> On Thu, Jul 27, 2017 at 10:14 AM, Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> wrote:
> > Hi,
> >
> > I found that postgresql.conf.sample is missing a comment
> > to note that changing max_logical_replication_workers requires
> > restart of the server.
> >
> > Other such parameters has the comments, so I think the new
> > parameter also needs this. Attached is a simple patch to fix
> > this.
> >
>
> Good point. Similarly, dynamic_shared_memory_type and event_source are
> required restarting to change but are not mentioned in
> postgresql.conf.sample. Should we add a comment as well?

I think so. The updated patch is attached.

>
> Regards,
>
> --
> Masahiko Sawada
> NIPPON TELEGRAPH AND TELEPHONE CORPORATION
> NTT Open Source Software Center

--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>