From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Add progress reporting to pg_verifybackup |
Date: | 2023-02-06 03:27:51 |
Message-ID: | CAD21AoCAk+XV9weyYkvxCKpVX6o2oEhr1qakjEXZrB-naOMYkQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Feb 6, 2023 at 9:35 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Sat, Feb 04, 2023 at 12:32:15PM +0900, Michael Paquier wrote:
> > That seems rather OK seen from here. I'll see about getting that
> > applied except if there is an objection of any kind.
>
> Okay, I have looked at that again this morning and I've spotted one
> tiny issue: specifying --progress with --skip-checksums does not
> really make sense.
I thought that too, but I thought it's better to ignore it, instead of
erroring out. For example, we can specify both --disable and
--progress options to pg_checksum commands, but we don't write any
progress information in this case.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
From | Date | Subject | |
---|---|---|---|
Next Message | John Naylor | 2023-02-06 04:04:57 | Re: cutting down the TODO list thread |
Previous Message | Jonathan S. Katz | 2023-02-06 03:08:44 | Re: First draft of back-branch release notes is done |