Re: synchronous_commit option is not visible after pressing TAB

On Wed, May 17, 2017 at 11:21 AM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 5/16/17 19:45, Michael Paquier wrote:
>> On Tue, May 16, 2017 at 8:18 PM, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com> wrote:
>>> While creating subscription - if we press TAB button to see the available
>>> parameters , synchronous_commit parameter is not visible.
>>>
>>> postgres=# CREATE SUBSCRIPTION sub123 CONNECTION 'dbname=postgres port=5000'
>>> PUBLICATION pub WITH (<Press TAB>
>>> CONNECT COPY_DATA CREATE_SLOT ENABLED SLOT_NAME
>>>
>>> synchronous_commit option is not visible
>>
>> Yes, and the items should be ordered alphabetically.
>
> Fixed. There were a few more things that needed tweaking, too.
>

In addition to that, attached patch fixes two tab completion issues.

* ALTER SUBSCRIPTION hoge_sub SET PUBLICATION hoge_pub [TAB]
-> Complete with "REFRESH ..." or "SKIP REFRESH".
* CREATE PUBLICATION hoge_pub FOR ALL TABLES [TAB] and CREATE
PUBLICATION hoge_pub FOR TABLE hoge_table [TAB]
-> Complete with "WITH ("

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center