| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Ants Aasma <ants(dot)aasma(at)eesti(dot)ee>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Reviewing freeze map code |
| Date: | 2016-05-17 19:15:37 |
| Message-ID: | CAD21AoBuNs7kBp=EAhFHEmffy6SaCZ0Bfsux3hAdp9n90abmVA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 16, 2016 at 10:49 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, May 10, 2016 at 10:40 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>> Or second way I came up with is having tool to remove particular _vm
>> file safely, which is executed via SQL or client tool like
>> pg_resetxlog.
>>
>> Attached updated VACUUM SCAN_ALL patch.
>> Please find it.
>
> We should support scan_all only with the new-style options syntax for
> VACUUM; that is, vacuum (scan_all) rename. That doesn't require
> making scan_all a keyword, which is good: this is a minor feature, and
> we don't want to bloat the parsing tables for it.
>
I agree with having new-style options syntax.
Isn't it better to have SCAN_ALL option without parentheses?
Syntaxes are;
VACUUM SCAN_ALL table_name;
VACUUM SCAN_ALL; -- for all tables on database
Regards,
--
Masahiko Sawada
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2016-05-17 19:25:29 | Parallel query and temp_file_limit |
| Previous Message | Teodor Sigaev | 2016-05-17 19:09:47 | pgsql: Allocate all page images at once in generic wal interface |