| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Arseny Sher <a(dot)sher(at)postgrespro(dot)ru> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: DROP SUBSCRIPTION hangs if sub is disabled in the same transaction |
| Date: | 2017-09-06 06:28:47 |
| Message-ID: | CAD21AoBuCHNP82MU+qC3SEBaiia46zb3EPn09-rTLdHVwN35XA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 4, 2017 at 11:43 PM, Arseny Sher <a(dot)sher(at)postgrespro(dot)ru> wrote:
> Arseny Sher <a(dot)sher(at)postgrespro(dot)ru> writes:
>
>> Attached patch fixes this by stopping workers before RO drop, as
>> already done in case when we drop replication slot.
>
> Sorry, here is the patch.
>
I could reproduce this issue, it's a bug. Added this to the open item.
The cause of this is commit 7e174fa7 which make subscription ddls kill
the apply worker only when transaction commit. I didn't look the patch
deeply yet but I'm not sure the approach that kills apply worker
before commit would be good.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2017-09-06 06:36:44 | Re: Tuple-routing for certain partitioned tables not working as expected |
| Previous Message | Michael Paquier | 2017-09-06 06:01:38 | Re: assorted code cleanup |