Re: replication_slot_catalog_xmin not explicitly initialized when creating procArray

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: "Wong, Yi Wen" <yiwong(at)amazon(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: replication_slot_catalog_xmin not explicitly initialized when creating procArray
Date: 2017-07-10 01:23:10
Message-ID: CAD21AoBjsyxUKpkBWaePnHKzPHQNKGrw3eE2TAm6-_su_vHTcw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 8, 2017 at 2:19 AM, Wong, Yi Wen <yiwong(at)amazon(dot)com> wrote:
> Hi,
>
>
> replication_slot_catalog_xmin is not explictly initialized to
> InvalidTransactionId.
>
>
> Normally, there isn't an issue with this because a freshly mmap'd memory is
> zeroed, and the value of InvalidTransactionId is 0.
>
> If the memory was not 0 for whatever reason, VACUUM would not behave as
> expected.
>
>
> See attached patch.
>

Thank you for the patch. This change makes sense to me.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-07-10 02:08:10 Re: pg_receivewal and messages printed in non-verbose mode
Previous Message Michael Paquier 2017-07-10 01:17:11 Re: Authentification method on client side checking