| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Duncan Sands <duncan(dot)sands(at)deepbluecap(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com> |
| Subject: | Re: Logical replication 'invalid memory alloc request size 1585837200' after upgrading to 17.5 |
| Date: | 2025-06-24 05:14:41 |
| Message-ID: | CAD21AoBfOJMMA_Xw6BKyWLGuhhZ6NNm+qBt-6P4gnmX3Xj_i5w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Tue, Jun 24, 2025 at 1:59 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Jun 24, 2025 at 10:24:03AM +0900, Masahiko Sawada wrote:
> > I've added the patch for that idea for discussion. I considered moving
> > the new cache-behavior-dependent test to another test file to minimize
> > the maintenance effort but didn't do that at this stage as the test
> > file has only a few tests.
>
> The spec test file only includes two short permutations, making the
> generated output really short. A secondary output file sounds fine to
> me as long as you document in the spec file the reason why the file is
> around, and your patch does that.
>
> +# This file contains cache-behavior-dependent test case. Their reults are
> [..]
> +# two expected-output files to cvoer both cases.
>
> Two typos in three lines of comments: s/reults/results/ and
> s/cvoer/cover/.
Thank you for reviewing the patch!
I've attached the updated patch. I'm going to push it barring further comments.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Fix-cache-dependent-test-failures-in-logical-deco.patch | application/octet-stream | 4.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2025-06-24 07:00:00 | Re: BUG #18953: Planner fails to build plan for complex query with LATERAL references |
| Previous Message | Michael Paquier | 2025-06-24 04:58:43 | Re: Logical replication 'invalid memory alloc request size 1585837200' after upgrading to 17.5 |