Re: subscription worker doesn't start immediately on eabled

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: subscription worker doesn't start immediately on eabled
Date: 2017-04-28 01:36:46
Message-ID: CAD21AoBZTrF8pucd3Xb+DKrx93Dr3zpNPOnSSB4zj4V7h_y5_A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 27, 2017 at 12:51 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Wed, Apr 26, 2017 at 4:03 PM, Kyotaro HORIGUCHI
> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> At Tue, 25 Apr 2017 14:45:03 -0400, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote in <3d6a1bd0-08ce-301d-3336-ec9f623a315d(at)2ndquadrant(dot)com>
>>> On 4/6/17 08:24, Kyotaro HORIGUCHI wrote:
>>> > The attached patch wakes up launcher when a subscription is
>>> > enabled. This fails when a subscription is enabled immedaitely
>>> > after disabling but it won't be a matter.
>>>
>>> committed, thanks
>>
>> Thanks!
>
> This patch makes me think that CREATE SUBSCRIPTION should also wake up
> the launcher only when ENABLE is specified. Patch attached. Thought?
>

That makes sense to me. Since NOCONNECT option changes some default
values including ENABLED to false I think we should apply it also when
NOCONNECT is specified?

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2017-04-28 01:43:04 Re: [PostgreSQL 10] default of hot_standby should be "on"?
Previous Message Masahiko Sawada 2017-04-28 01:20:48 Re: Interval for launching the table sync worker