Re: Failure assertion in GROUPS mode of window function in current HEAD

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Failure assertion in GROUPS mode of window function in current HEAD
Date: 2018-07-12 15:33:42
Message-ID: CAD21AoBS8CKmi=m1dYk3_K5Y4cusJ+P9jUvTV29z_kKyGSfGLw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 13, 2018 at 12:17 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> writes:
>> I think we also can update the doc about that GROUPS offset mode
>> requires ORDER BY clause. Thoughts? Attached patch updates it.
>
> Ooops, I forgot to check the docs. This isn't quite the right fix
> though --- the problem is that there's a sentence at the end of that
> para that now says exactly the wrong thing. I fixed that.
>

Yeah, that's not the right fix. Thank you for fixing!

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Teodor Sigaev 2018-07-12 15:53:18 Re: [PATCH] btree_gist: fix union implementation for variable length columns
Previous Message Andrew Dunstan 2018-07-12 15:28:46 Re: _isnan() on Windows