Re: effective_wal_level is not decreasing after using REPACK (CONCURRENTLY)

On Wed, May 27, 2026 at 2:20 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2026-May-27, Masahiko Sawada wrote:
>
> > > Some buildfarm members reported failures[1][2]. The newly added test
> > > works only on builds without injection points because the logical slot
> > > "test_slot" is removed during tests using injection points, otherwise
> > > it still exists on the primary server at the end of
> > > 051_effective_wal_level.pl.
> > >
> >
> > I've attached the patch to fix the issue by moving the new test
> > earlier in the test script, so it no longer depends on slot state.
>
> Ah, so that's why the submitted patch had the test placed at an awkward
> place in the file! I moved it to the end because I failed to realize
> this problem. I didn't see this failure locally, and CI didn't see it
> either. I wonder if we're lacking coverage of the no-injection-points
> case in CI.

I happened to notice the failure when testing other codes locally. It
would be good to have no-injection-points cases in CI.

> Thanks for the patch, please feel free to push it.

Pushed. Thank you for reviewing the patch!

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com