Re: parallel vacuum comments

On Tue, Nov 30, 2021 at 3:00 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Nov 30, 2021 at 11:03 AM houzj(dot)fnst(at)fujitsu(dot)com
> <houzj(dot)fnst(at)fujitsu(dot)com> wrote:
> >
> > On Mon, Nov 29, 2021 11:38 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > >
> >
> > 2)
> > + /* Reinitialize the parallel context to relaunch parallel workers */
> > + if (!pvs->first_time)
> >
> > It seems the ParallelVacuumState::first_time was not initialized before ?
> >
>
> Yeah, I also notice this while looking at the patch.

Thank you for the comments, Amit and Hou.

>
> One more thing it seems the patch has removed even the existing error
> callback from parallel_vacuum_main. I suggested that we can enhance or
> add a new one if required in a separate patch but let's keep the
> current one as it is.

Understood.

>
> Can we think of splitting the patch in the following manner: (a) the
> patch to get rid of bitmap to represent whether particular index
> supports parallel vacuum and rename of functions (b) any other stuff
> to improve the current implementation, (c) move the parallel vacuum
> related code to a separate file?

Okay, I'll split the patch and submit them.

Regards,

--
Masahiko Sawada
EDB: https://www.enterprisedb.com/