| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Comment and function argument names are mismatched in bugmgr.c. |
| Date: | 2016-07-02 02:16:33 |
| Message-ID: | CAD21AoBN2Kzn0ARuvVtD1FV8rSyoyGcNBhyEb2xGtVgzTTT1bA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jul 2, 2016 at 6:34 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> Hi,
>
> On 2016-06-23 16:24:12 +0900, Masahiko Sawada wrote:
>> By commit 428b1d6b, function WritebackContextInit is added but the
>> comment of this function seems to be incorrect.
>> *max_coalesce variable doesn't exist at anywhere.
>> Also, I think it should be fixed that the argument name of this
>> function does not match function declare in buf_internal.h.
>> Patch for that attached.
>
> Fix looks good to me, and your 'bugmgr.c' typo in $subject made me laugh
> ;). Pushed.
Oops, I realized it now :)
Thanks!
Regards,
--
Masahiko Sawada
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2016-07-02 02:20:14 | Re: Documentation fixes for pg_visibility |
| Previous Message | Noah Misch | 2016-07-02 02:05:06 | Re: Bug in batch tuplesort memory CLUSTER case (9.6 only) |