| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Issue with pg_stat_subscription_stats |
| Date: | 2022-07-06 02:41:46 |
| Message-ID: | CAD21AoBMmO-vdm5-as2jnazUxOQnp6QjOc3hU87j1C3fmCpdRA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 6, 2022 at 10:48 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> On 2022-07-06 10:25:02 +0900, Masahiko Sawada wrote:
> > > I think most of this could just be pgstat_reset_entry().
> >
> > I think pgstat_reset_entry() doesn't work for this case as it skips
> > resetting the entry if it doesn't exist.
>
> True - but a pgstat_get_entry_ref(create = true); pgstat_reset_entry(); would
> still be shorter?
Indeed. I've updated the patch.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Create-subscription-stats-entry-at-CREATE-SUBSCRI.patch | application/octet-stream | 4.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2022-07-06 02:45:57 | Re: First draft of the PG 15 release notes |
| Previous Message | Kyotaro Horiguchi | 2022-07-06 02:38:42 | Re: pg_rewind: warn when checkpoint hasn't happened after promotion |