Re: Issue with pg_stat_subscription_stats

From: Andres Freund <andres(at)anarazel(dot)de>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Issue with pg_stat_subscription_stats
Date: 2022-07-06 01:48:20
Message-ID: 20220706014820.lffyrbwmwl74shti@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022-07-06 10:25:02 +0900, Masahiko Sawada wrote:
> > I think most of this could just be pgstat_reset_entry().
>
> I think pgstat_reset_entry() doesn't work for this case as it skips
> resetting the entry if it doesn't exist.

True - but a pgstat_get_entry_ref(create = true); pgstat_reset_entry(); would
still be shorter?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-07-06 01:50:10 Re: pg_upgrade (12->14) fails on aggregate
Previous Message David Rowley 2022-07-06 01:34:37 Re: tuplesort Generation memory contexts don't play nicely with index builds