| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Sami Imseih <samimseih(dot)pg(at)gmail(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Subject: | Re: parallel autovacuum: Propagate track_cost_delay_timing to parallel workers |
| Date: | 2026-09-28 23:45:21 |
| Message-ID: | CAD21AoB9JVR9EuMjQ1oXP9Fx5EHPrO45Cv8V8gqNQ8HNx9w5wg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Fri, Sep 25, 2026 at 8:41 AM Sami Imseih <samimseih(dot)pg(at)gmail(dot)com> wrote:
>
> Hi,
>
> Here is a small patch to propagate track_cost_delay_timing to parallel
> autovacuum workers. 1ff3180ca01 propagates the cost-based delay
> parameters via PVSharedCostParams but left this one out, so a worker keeps
> the value it inherited at parallel start, and workers will not report
> sleep time if the GUC is turned on mid-flight.
>
> This only impacts delay reporting, but should be backpatched to 19 which
> introduced parallel autovacuum.
>
> CC Sawada-san and Zsolt since there is a related discussion in [1], though
> that one is about throttling.
Thank you for the report and the patch! Good catch. The patch looks
good to me overall and works as expected. I have one minor comment
though:
int cost_page_miss;
+ bool track_delay_timing;
} PVSharedCostParams;
I think using track_cost_delay_timing seems better in terms of greppability.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2026-09-28 23:48:59 | Re: parallel autovacuum: Propagate track_cost_delay_timing to parallel workers |
| Previous Message | Masahiko Sawada | 2026-09-28 23:29:25 | Re: Parallel autovacuum: leader crashes when no DSM segment can be created |