From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Small documentation improvement for ALTER SUBSCRIPTION |
Date: | 2021-07-13 01:05:08 |
Message-ID: | CAD21AoB7ncijakqVbgrvn1jWgayjz1r5TH5OLWfog39GCfH7xw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On Thu, Jul 8, 2021 at 10:14 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 8 Jul 2021, at 15:00, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> > I think we can improve it by changing to
> > '<replaceable>refresh_option</replaceable>'. Thoughts?
>
> My first thought was that the existing wording is clearer, referring to
> “options to refresh”. But thinking on it more, it’s easy to see someone
> confusing the options part as referring to the (bool) “option” to refresh
> rather than refresh_option. I think your version is an improvement.
Thanks for your comments!
I've added this patch to the next commitfest so as not to forget.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro Horiguchi | 2021-07-13 01:22:02 | Re: Fix comments of heap_prune_chain() |
Previous Message | Michael Paquier | 2021-07-13 00:47:15 | Re: [PATCH] Pull general SASL framework out of SCRAM |