| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_wal/RECOVERYHISTORY file remains after archive recovery |
| Date: | 2019-09-30 08:07:08 |
| Message-ID: | CAD21AoB6NVd4FPc=UPc7jxOgduzVMEUhff=c5b2oZ=SwW3Bjyg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 30, 2019 at 5:03 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Sep 30, 2019 at 12:53:58PM +0900, Masahiko Sawada wrote:
> > I think that the above checks are always true because isnt() function
> > checks if the 1st argument and 2nd argument are not the same.
>
> Dammit. I overlooked this part of the module's doc.
>
> > I've attached the updated version patch including the tests. Please
> > review it.
>
> Thanks, your test allows to reproduce the original problem, so that's
> nice. I don't have much to say, except some improvements to the
> comments of the test as per the attached. What do you think?
Thank you for updating! The comment in your patch is much better.
Regards,
--
Masahiko Sawada
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Konstantin Knizhnik | 2019-09-30 08:29:44 | Re: Removing unneeded self joins |
| Previous Message | Michael Paquier | 2019-09-30 08:03:40 | Re: pg_wal/RECOVERYHISTORY file remains after archive recovery |