From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, David Rowley <dgrowleyml(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Subject: | Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode |
Date: | 2023-04-28 06:44:04 |
Message-ID: | CAD21AoB1FBNSYW_aTMsUFv-Dqp_UDoY=iBNHZNjEL9Efc58tuw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Apr 26, 2023 at 9:59 PM Melanie Plageman
<melanieplageman(at)gmail(dot)com> wrote:
>
>
> On Wed, Apr 26, 2023 at 8:31 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>>
>> > On 26 Apr 2023, at 13:26, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>> > On Wed, 26 Apr 2023, 8:48 pm Masahiko Sawada, <sawada(dot)mshk(at)gmail(dot)com <mailto:sawada(dot)mshk(at)gmail(dot)com>> wrote:
>>
>> > It works but I think we might want to add the unit kB for
>> > understandability and consistency with other GUC_UNIT_KB parameters.
>> > I've attached a small patch that adds the unit and aligns the indent
>> > of the comments to the perimeter parameters.
>> >
>> > I'm not currently able to check, but if work_mem has a unit in the sample conf then I agree that vacuum_buffer_usage_limit should too.
>>
>> +1 work_mem and all other related options in this section has a unit in the
>> sample conf so adding this makes sense.
>
>
> Agreed.
> for the patch, the other GUCs have a tab instead of a space between the unit and the "#" of the first comment.
> (not the fault of this patch but probably makes sense to fix now).
> Otherwise, LGTM
Thanks for the review! Pushed after incorporating a comment from Melanie.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2023-04-28 07:10:05 | Re: Add PQsendSyncMessage() to libpq |
Previous Message | Masahiko Sawada | 2023-04-28 06:18:01 | Re: Perform streaming logical transactions by background workers and parallel apply |