| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Comment in snapbuild.c file |
| Date: | 2017-08-10 04:15:28 |
| Message-ID: | CAD21AoB+ycZ2z-4Ye=6MfQ_r0aV5r6cvVPw4kOyPdp6bHqQoBQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
In snapbuild.c file, there is a comment as follows.
* NB: Because of that xmax can be lower than xmin, because we only
* increase xmax when a catalog modifying transaction commits. While odd
* looking, it's correct and actually more efficient this way since we hit
* fast paths in tqual.c.
*/
Maybe we can get rid of the second "because" in the first sentence?
Attached patch.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| Attachment | Content-Type | Size |
|---|---|---|
| fix_comment_in_snapbuild_c.patch | text/x-patch | 991 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-08-10 04:37:03 | Re: Remove 1MB size limit in tsvector |
| Previous Message | Thomas Munro | 2017-08-10 03:58:40 | Re: Partition-wise join for join between (declaratively) partitioned tables |