| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: parallel vacuum comments |
| Date: | 2021-11-03 02:54:20 |
| Message-ID: | CAD21AoAy_ZjNGpyEzWfegmPaaGFSnbcmutiv_spGvm4isnTT_g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 3, 2021 at 11:53 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>
> On Tue, Nov 2, 2021 at 7:35 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > It returns true in the above condition but it should return false
> > since the index doesn't support parallel index cleanup at all. It
> > seems that this bug was introduced by commit b4af70cb21 (therefore
> > exists only in PG14) which flipped the return values of this function
> > but missed one place. The index AMs that don't support parallel index
> > cleanup at all are affected by this bug. Among the supported index AM
> > in the core, hash indexes are affected but since they just return the
> > number of blocks during vacuumcleanup it would not become a serious
> > consequence.
> >
> > I've attached a patch to fix it.
>
> I pushed your fix just now.
Thanks!
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-11-03 03:00:33 | Re: Added schema level support for publication. |
| Previous Message | Peter Geoghegan | 2021-11-03 02:53:09 | Re: parallel vacuum comments |