Re: effective_wal_level is not decreasing after using REPACK (CONCURRENTLY)

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: shveta malik <shveta(dot)malik(at)gmail(dot)com>, Imran Zaheer <imran(dot)zhir(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, shveta malik <shvetamalik(at)gmail(dot)com>
Subject: Re: effective_wal_level is not decreasing after using REPACK (CONCURRENTLY)
Date: 2026-05-27 19:21:18
Message-ID: CAD21AoAxfxzWQxAkOFPns1i1Xx1UdwaTR5Hj5ez36bn5vzjqbA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 27, 2026 at 11:56 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Wed, May 27, 2026 at 11:25 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > On Wed, May 27, 2026 at 11:20 AM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> > >
> > > On 2026-May-26, shveta malik wrote:
> > >
> > > > On Tue, May 26, 2026 at 3:09 PM Imran Zaheer <imran(dot)zhir(at)gmail(dot)com> wrote:
> > > > >
> > > > > Hi,
> > > > >
> > > > > Thanks Shveta, I agree with the additional sanity checks and comments.
> > > >
> > > > Thanks, v3 LGTM.
> > >
> > > Thanks! Pushed with some cosmetic changes.
> >
> > Thank you for pushing the patch!
>
> Some buildfarm members reported failures[1][2]. The newly added test
> works only on builds without injection points because the logical slot
> "test_slot" is removed during tests using injection points, otherwise
> it still exists on the primary server at the end of
> 051_effective_wal_level.pl.
>

I've attached the patch to fix the issue by moving the new test
earlier in the test script, so it no longer depends on slot state.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v1-0001-Fix-051_effective_wal_level.pl-on-builds-without-.patch text/x-patch 2.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Srinivas Kumar 2026-05-27 20:27:19 DBeaver Experiencing timeouts while connecting to New Linux PostgreSql server
Previous Message Peter Geoghegan 2026-05-27 19:11:52 Re: index prefetching