Re: Fix showing XID of a spectoken lock in an incorrect field of pg_locks view.

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix showing XID of a spectoken lock in an incorrect field of pg_locks view.
Date: 2023-01-06 12:30:04
Message-ID: CAD21AoAx8FT0aghtKYUioLjBr4kzfxNYXHT2pTZ8V2zmkjzvpg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 6, 2023 at 9:00 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Jan 5, 2023 at 11:46 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > Agreed. Attached the updated patch.
> >
>
> Thanks, the patch looks good to me. I think it would be probably good
> to backpatch this but it has the potential to break some monitoring
> scripts which were using the wrong columns for transaction id and spec
> token number.

Right.

> As this is not a very critical issue and is not reported
> till now, so it may be better to leave backpatching it. What do you
> think?

Considering the compatibility, I'm inclined to agree not to backpatch
it. If someone complains about the current behavior in back branches
in the future, we can backpatch it.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Borisov 2023-01-06 12:45:29 Re: POC: Lock updated tuples in tuple_update() and tuple_delete()
Previous Message Dean Rasheed 2023-01-06 12:18:44 Re: [PATCH] psql: Add tab-complete for optional view parameters