| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Zhijie Hou <houzhijie22(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add a hook for handling logical decoding messages on subscribers. |
| Date: | 2026-11-19 23:42:06 |
| Message-ID: | CAD21AoAtSSr_khQCvdvoozU1EZ7A1S5_X4-6NXZA4rsx0ZxzMQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 19, 2026 at 2:49 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Nov 18, 2026 at 12:13 PM Bertrand Drouvot
> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> >
> > On Tue, Nov 17, 2026 at 02:14:15PM -0800, Masahiko Sawada wrote:
> > > On Tue, Nov 17, 2026 at 12:14 AM Bertrand Drouvot
> > > <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> >
> > > Given that the 0001 patch is not backpatched, I think the subscriber
> > > should request the messages option only from v20 or later publishers,
> > > like it doesn't send the origin option to publishers older than v16.
> > > The patch already checks the publisher version there, so we just need
> > > to raise it from v14 to v20. What do you think?
> >
> > One difference with origin is that older publishers do not support that option
> > at all, whereas v14 through v19 publishers support messages and the issue occurs
> > only when streaming is enabled.
> >
> > I wonder if it would make sense to request messages from those publishers when
> > streaming is disabled, and require v20 or later when streaming is enabled?
> >
>
> We could use one of the ideas proposed or just leave as it is. It is
> possible that there is no such use till now, so, adding more version
> checking in the code for such things may not add much value.
I'd like to keep it simple and require v20 or later regardless of the
streaming option. Since streaming defaults to parallel, the
subscribers would have to give up the performance benefit of
streaming. So I don't think it's worth adding another check for them,
as Amit said.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-11-19 23:49:32 | Re: Assertion failure with temporary relations in single-user mode |
| Previous Message | Tomas Vondra | 2026-11-19 23:22:19 | Re: A bug in recovery prefetcher, triggering asserts / FATAL: checkpoint request failed |