From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Small documentation improvement for ALTER SUBSCRIPTION |
Date: | 2021-08-11 07:57:51 |
Message-ID: | CAD21AoAknsOd5tdQ90-7QCQXYOUtxBeyun339rQmxuhr77XT6A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Aug 10, 2021 at 12:28 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Tue, Aug 10, 2021 at 6:31 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > On Mon, Aug 9, 2021 at 1:01 PM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> > >
> > > On Mon, Aug 9, 2021 at 12:46 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > But "REFRESH PUBLICATION refresh_option" seems wrong in terms of SQL
> > syntax, not?
> >
> > Given there could be multiple options how about using
> > "<replaceable>refresh_options</replaceable>"? That is, the sentence
> > will be:
> >
> > Additionally, <replaceable>refresh_options</replaceable> as described
> > under <literal>REFRESH PUBLICATION</literal> may be specified,
> > except in the case of <literal>DROP PUBLICATION</literal>.
> >
>
> Normally (at least on this doc page), we use this tag for some defined
> option, syntax and as refresh_options is none of them, it would look a
> bit awkward.
Indeed.
Thinking more the idea proposed by Peter Smith, it looks unnatural to
me, especially the part of "REFRESH PUBLICATION refresh_option":
Additionally, refresh options as described
under <literal>REFRESH PUBLICATION</literal>
<replaceable>refresh_option</replaceable> may be specified,
except in the case of <literal>DROP PUBLICATION</literal>.
As an alternative idea, how about using the "refresh_option of REFRESH
PUBLICATION" instead ? That is,
Additionally, refresh options as described in
<replaceable>refresh_option</replaceable> of
<literal>REFRESH PUBLICATION</literal> may be specified,
except in the case of <literal>DROP PUBLICATION</literal>.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Paul Guo | 2021-08-11 07:58:51 | Re: standby recovery fails (tablespace related) (tentative patch and discussion) |
Previous Message | Shruthi Gowda | 2021-08-11 07:41:05 | Re: storing an explicit nonce |