Re: Transactions involving multiple postgres foreign servers

From: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
To: vinayak <Pokale_Vinayak_q3(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Vinayak Pokale <vinpokale(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>
Subject: Re: Transactions involving multiple postgres foreign servers
Date: 2017-03-07 08:04:57
Message-ID: CAD21AoAZAQB36S2kZ1qEiTHx1W29P5MnLssqHSbu5wcWVh-Zgg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Fri, Mar 3, 2017 at 1:24 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> On Thu, Mar 2, 2017 at 11:56 AM, vinayak
> <Pokale_Vinayak_q3(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>>
>> On 2017/02/28 16:54, Masahiko Sawada wrote:
>>
>> I've created a wiki page[1] describing about the design and
>> functionality of this feature. Also it has some examples of use case,
>> so this page would be helpful for even testing. Please refer it if
>> you're interested in testing this feature.
>>
>> [1] 2PC on FDW
>> <https://wiki.postgresql.org/wiki/2PC_on_FDW>
>>
>> Thank you for creating the wiki page.
>
> Thank you for looking at this patch.
>
>> In the "src/test/regress/pg_regress.c" file
>> - * xacts. (Note: to reduce the probability of unexpected
>> shmmax
>> - * failures, don't set max_prepared_transactions any higher
>> than
>> - * actually needed by the prepared_xacts regression test.)
>> + * xacts. We also set max_fdw_transctions to enable testing
>> of atomic
>> + * foreign transactions. (Note: to reduce the probability of
>> unexpected
>> + * shmmax failures, don't set max_prepared_transactions or
>> + * max_prepared_foreign_transactions any higher than
>> actually needed by the
>> + * corresponding regression tests.).
>>
>> I think we are not setting the "max_fdw_transctions" anywhere.
>> Is this correct?
>
> This comment is out of date. Will fix.
>
>>
>> In the "src/bin/pg_waldump/rmgrdesc.c" file following header file used two
>> times.
>> + #include "access/fdw_xact.h"
>> I think we need to remove one line.
>>
>
> Not necessary. Will get rid of it.
>
> Since these are not feature bugs I will incorporate these when making
> update version patches.
>

Attached updated set of patches.
The differences from previous patch are,
* Fixed a few bugs.
* Separated previous 000 patch into two patches.
* Changed name pg_fdw_xact_resovler contrib module to
fdw_transaction_resolver.
* Incorporated review comments got from Vinayak

Please review these patches.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment Content-Type Size
000_register_local_write_v9.patch application/octet-stream 3.3 KB
001_support_fdw_xact_v9.patch application/octet-stream 108.6 KB
002_pgfdw_support_atomic_commit_v9.patch application/octet-stream 43.4 KB
003_fdw_transaction_resolver_contrib_v9.patch application/octet-stream 14.5 KB
004_regression_test_for_fdw_xact_v9.patch application/octet-stream 7.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Oleg Bartunov 2017-03-07 09:21:59 Re: SQL/JSON in PostgreSQL
Previous Message Amit Langote 2017-03-07 07:15:32 Re: contrib modules and relkind check