Re: [PoC] Improve dead tuple storage for lazy vacuum

On Fri, Mar 8, 2024 at 10:04 AM John Naylor <johncnaylorls(at)gmail(dot)com> wrote:
>
> On Thu, Mar 7, 2024 at 11:15 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > It looks like it requires a link with pgport_srv but I'm not sure. It
> > seems that the recent commit 1f1d73a8b breaks CI, Windows - Server
> > 2019, VS 2019 - Meson & ninja, too.
>
> Unfortunately, none of the Windows animals happened to run both after
> the initial commit and before removing the (seemingly useless on our
> daily platfoms) link. I'll confirm on my own CI branch in a few
> minutes.

Yesterday I've confirmed the something like the below fixes the
problem happened in Windows CI:

--- a/src/test/modules/test_radixtree/meson.build
+++ b/src/test/modules/test_radixtree/meson.build
@@ -12,6 +12,7 @@ endif

test_radixtree = shared_module('test_radixtree',
test_radixtree_sources,
+ link_with: host_system == 'windows' ? pgport_srv : [],
kwargs: pg_test_mod_args,
)
test_install_libs += test_radixtree

But I'm not sure it's the right fix especially because I guess it
could raise "AddressSanitizer: odr-violation" error on Windows.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com