From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
Cc: | Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: DROP SUBSCRIPTION and ROLLBACK |
Date: | 2017-03-05 02:20:00 |
Message-ID: | CAD21AoAMUm6A8CWWmrhZr_PqeAy=XTj_o6ozn1DUW3FObd-Zmw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Mar 4, 2017 at 1:46 PM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> On 3/3/17 13:58, Petr Jelinek wrote:
>> On 23/02/17 08:24, Masahiko Sawada wrote:
>>> Attached updated version patches. Please review these.
>>>
>>
>> This version looks good to me, I'd only change the
>>
>>> + PreventTransactionChain(isTopLevel, "CREATE SUBSCRIPTION CREATE SLOT");
>>
>> to "CREATE SUBSCRIPTION ... CREATE SLOT" as that's afaik how we do it
>> for other commands (and same with DROP).
>
> I have committed fixes for these issues.
Thanks!
>
> I didn't like the syntax change in DROP SUBSCRIPTION, so I have just
> fixed the parsing of the existing syntax. We can discuss syntax changes
> separately.
Understood.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | David Steele | 2017-03-05 03:14:54 | Re: Block level parallel vacuum WIP |
Previous Message | Masahiko Sawada | 2017-03-05 02:08:10 | Re: Block level parallel vacuum WIP |