| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: Copy function for logical replication slots |
| Date: | 2019-04-06 02:49:33 |
| Message-ID: | CAD21AoAJdXvraW=YGPJ4Nes9gXfW6mVEfVdKRHjBics4Kx7c6g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Apr 6, 2019 at 6:16 AM Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
> Pushed this.
Thank you!
>
> The mechanism of creating a new slot from the source, then later
> advancing the LSN of the new slot using the updated values from the
> source slot, seems quite clever. I reworded the comment that explained
> how it is supposed to work; please double-check to ensure I got it
> right.
It looks good to me other than a typo pointed out by Petr.
>
> I renamed the opr_sanity-induced wrappers. I see no reason to get
> very precise about what's what ... these functions are all identical.
>
Agreed.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-04-06 03:03:11 | Re: Speed up transaction completion faster after many relations are accessed in a transaction |
| Previous Message | Masahiko Sawada | 2019-04-06 02:31:31 | Re: New vacuum option to do only freezing |