Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output

On Tue, Dec 21, 2021 at 2:39 AM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>
> On Mon, Nov 29, 2021 at 6:51 PM Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> > Attached is a WIP patch doing this.
>
> This has bitrot, so I attach v2, mostly just to keep the CFTester
> status green. The only real change is one minor simplification to how
> we set everything up, inside heap_vacuum_rel().

I've looked at the patch and here are comments:

@@ -3076,16 +3021,12 @@ lazy_cleanup_one_index(Relation indrel,
IndexBulkDeleteResult *istat,
LVRelState *vacrel)
{
IndexVacuumInfo ivinfo;
- PGRUsage ru0;
LVSavedErrInfo saved_err_info;

- pg_rusage_init(&ru0);
-
ivinfo.index = indrel;
ivinfo.analyze_only = false;
ivinfo.report_progress = false;
ivinfo.estimated_count = estimated_count;
- ivinfo.message_level = elevel;

I think we should set message_level. Otherwise, index AM will set an
invalid log level, although any index AM in core seems not to use it.

---
- /*
- * Update error traceback information. This is the
last phase during
- * which we add context information to errors, so we
don't need to
- * revert to the previous phase.
- */

Why is this comment removed? ISTM this comment is still valid.

Regards,

--
Masahiko Sawada
EDB: https://www.enterprisedb.com/