Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c

On Mon, Aug 18, 2025 at 12:02 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Aug 18, 2025 at 03:58:45PM +0900, Michael Paquier wrote:
> > That's enough to reproduce the MULL pointer dereference, thanks!
> >
> > I would suggest to add a description at the top of foreign_recheck,
> > documenting the purpose of the test.
> >
> > +# "s0_lock" execute a FOR UPDATE query but it stops before locking the result
> > s/execute/executes/, with an 's'.
>
> Another thing that I've noticed has been forgotten: postgres_fdw's
> .gitignore needs entries for output_iso/ and tmp_check_iso/. Based on
> git-prompt, GIT_PS1_SHOWUNTRACKEDFILES reports these paths after a
> test run.

Thank you for reviewing the patch! I'll incorporate these comments in
the next version patch.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com