| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>, Duncan Sands <duncan(dot)sands(at)deepbluecap(dot)com>, Alexander Lakhin <exclusion(at)gmail(dot)com> |
| Subject: | Re: Logical replication 'invalid memory alloc request size 1585837200' after upgrading to 17.5 |
| Date: | 2025-06-24 01:24:03 |
| Message-ID: | CAD21AoACfSCfWv=Jtq2AjDyAKspkhNHN7ePvXyASMphYuDJPuw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, Jun 23, 2025 at 11:05 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Mon, Jun 23, 2025 at 9:03 PM Hayato Kuroda (Fujitsu)
> <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> >
> > Dear Sawada-san,
> >
> > > One solution is to have two expected-output files to cover both cases.
> > > We do a similar thing for the plpgsql_cache.sql test case. What do you
> > > think?
> >
> > Personally I don't like the approach because XXX_1.out can be easily missed to be
> > updated, but it is not a strong opinion.
>
> I think that we have only a few releases for v13 and there would not
> likely be many cases where we need to update _1.out file. But I'm open
> to other ideas. Do you prefer removing the test from v13? I'm not sure
> that just because it's easy to miss updating a _1.out file is a good
> reason to remove tests.
>
I've added the patch for that idea for discussion. I considered moving
the new cache-behavior-dependent test to another test file to minimize
the maintenance effort but didn't do that at this stage as the test
file has only a few tests.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-invalidation-distribution-test-failure-in-log.patch | application/octet-stream | 3.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2025-06-24 03:51:06 | Re: Logical replication 'invalid memory alloc request size 1585837200' after upgrading to 17.5 |
| Previous Message | Ajin Cherian | 2025-06-24 00:20:06 | Re: BUG #18509: Logical decoding behaves badly when processing a change record for a table with altered column |