Re: Logical replication 'invalid memory alloc request size 1585837200' after upgrading to 17.5

On Tue, Jun 24, 2025 at 6:54 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> On Mon, Jun 23, 2025 at 11:05 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > On Mon, Jun 23, 2025 at 9:03 PM Hayato Kuroda (Fujitsu)
> > <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> > >
> > > Dear Sawada-san,
> > >
> > > > One solution is to have two expected-output files to cover both cases.
> > > > We do a similar thing for the plpgsql_cache.sql test case. What do you
> > > > think?
> > >
> > > Personally I don't like the approach because XXX_1.out can be easily missed to be
> > > updated, but it is not a strong opinion.
> >
> > I think that we have only a few releases for v13 and there would not
> > likely be many cases where we need to update _1.out file. But I'm open
> > to other ideas. Do you prefer removing the test from v13? I'm not sure
> > that just because it's easy to miss updating a _1.out file is a good
> > reason to remove tests.
> >
>
> I've added the patch for that idea for discussion. I considered moving
> the new cache-behavior-dependent test to another test file to minimize
> the maintenance effort but didn't do that at this stage as the test
> file has only a few tests.
>

Your proposal sounds good to me.

--
With Regards,
Amit Kapila.