Re: Copy function for logical replication slots

On Fri, Jul 6, 2018 at 9:21 AM, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Thu, Jul 05, 2018 at 05:24:48PM +0900, Masahiko Sawada wrote:
>> Yes, you're right. To guarantee that restart LSN of copied slot is
>> available, it seems to me that it's better to copy new slot while
>> holding the origin slot as you mentioned before. Since the replication
>> slot creation code assumes that a process creating a new slot doesn't
>> have any slots we should save origin slot temporary and create new
>> one, and then restore it.
>
> This will require some refactoring first I think as most of the slot
> routines assume that the process owning it is the one doing the calls,
> so this has a string smell of a patch set being splitted.
>
>> It might be a bit tricky but would work fine.
>
> Sawada-san, will you be able to rewrite this patch soon or should it be
> moved to the next commit fest? I would suggest to do the latter as this
> is no small work, and this needs careful thoughts.

I think that this patch might be splitted but I will be able to send
an updated patch in the next week. As you suggestion this patch needs
more careful thoughts. I'll move this patch to the next commit fest if
I will not be able to sent it. Is that okay?

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center