Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string

On Wed, Mar 12, 2025 at 5:04 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Thu, 13 Mar 2025 at 10:34, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > BTW how did you catch the warning? I checked before the push if the
> > change had passed the CI tests (completed with green status). But when
> > checking the build log now, I can see the warning in the build logs.
>
> My workflow is, when still working in the feature branch, to always do
> "perl src/tools/pgindent/pgindent --commit HEAD" once I'm ready for it
> to be pushed (assuming there's only 1 commit). If there's any diff
> I'll "git commit -a --fixup HEAD && git rebase -i master" and adjust
> the commit type of the fixup commit as "fixup" (or "f"). I'll then do
> a final "git format-patch" and "git am" that to git master and run the
> tests before pushing.

Thank you for sharing. I'll integrate the workflow with mine.

> I tend to never do any fixups in git master as
> I'm too scared I'll one day push one of them accidentally.

Yeah, that's important.

Thank you for fixing the indentation issue (b955df44340). I've checked
the issue with CI before pushing but I missed the fix for some reason.
That's my fault.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com