| From: | Xianbin Zhu <xianbin(dot)aaronzhu(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | [PATCH v1] psql: complete ALTER ROLE ... IN DATABASE ... RESET |
| Date: | 2026-03-29 07:05:11 |
| Message-ID: | CAD-rTHmcFSsG8N14G8BZeGSgY94v=N0NC-CHfnZegfYzEYnNQw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi hackers,
As discussed, here's a patch to add psql tab-completion support for:
ALTER ROLE/USER <name> IN DATABASE <db> RESET ...
Changes:
- Add completion path for "... IN DATABASE <db> RESET"
- Offer GUC names and ALL after RESET
- Add tab-completion test coverage in src/bin/psql/t/010_tab_completion.pl
Testing:
- make -j8
- make check (all tests passed in my environment)
Patch attached.
Thanks,
xianbinzhu
On Sun, Mar 29, 2026 at 2:50 PM Xianbin Zhu <xianbin(dot)aaronzhu(at)gmail(dot)com>
wrote:
> Hi hackers,
>
> I'd like to work on a small psql tab-completion improvement.
>
> Problem:
> psql currently has a missing completion path for:
> ALTER ROLE <role> IN DATABASE <db> RESET ...
>
> There is an in-code TODO marker for this case in
> src/bin/psql/tab-complete.in.c.
>
> Proposal:
> - Add completion support after "... IN DATABASE <db> RESET"
> - Reuse existing completion behavior/style used by ALTER ROLE ... RESET
> - Add regression coverage in src/bin/psql/t/010_tab_completion.pl
>
> Non-goals:
> - No backend behavior changes
> - No SQL grammar changes
>
> If this direction looks good, I can send a patch.
>
> Thanks,
> xianbinzhu
>
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-psql-complete-ALTER-ROLE-.-IN-DATABASE-.-RESET.patch | application/octet-stream | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2026-03-29 10:42:47 | Re: Allow to collect statistics on virtual generated columns |
| Previous Message | Xianbin Zhu | 2026-03-29 06:50:28 | [PROPOSAL] psql tab completion: support ALTER ROLE ... IN DATABASE ... RESET |