Re: [PATCH] Refactor *_abbrev_convert() functions

From: Aditya Gollamudi <adigollamudi(at)gmail(dot)com>
To: Aleksander Alekseev <aleksander(at)tigerdata(dot)com>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Refactor *_abbrev_convert() functions
Date: 2026-01-24 22:27:04
Message-ID: CAD-KL_H-jscSsTRa89W9k5+jaovTYQQv24J4f_cKi-Yr7E0PHw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 13, 2026 at 4:34 AM Aleksander Alekseev <
aleksander(at)tigerdata(dot)com> wrote:

> Hi,
>
> Now when all Datums are 64-bit values we can simplify the code by
> using murmurhash64(). This refactoring was previously suggested by
> John Naylor [1].
>
> [1]:
> https://postgr.es/m/CANWCAZbMyrijdR0xc-4SqpNJBHMEwRZccBK4fa0aquNpq2Uj7w%40mail.gmail.com
>
> --
> Best regards,
> Aleksander Alekseev
>

Hi,

I reviewed this change and the surrounding code and this seems good!
All tests pass locally for me. Hopefully this gets picked up soon.

Regards,
Adi Gollamudi

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2026-01-24 23:03:00 Re: Buffer locking is special (hints, checksums, AIO writes)
Previous Message Robert Treat 2026-01-24 21:36:38 Re: Optional skipping of unchanged relations during ANALYZE?