| From: | Paul Martinez <paulmtz(at)google(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] pg_hba.conf error messages for logical replication connections |
| Date: | 2021-02-01 20:12:43 |
| Message-ID: | CACqFVBYaJmJve0hzU9YbjpKwZZ81eGWHM7Lc_XG7UMjYygdC9Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 29, 2021 at 8:41 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> Yeah, hints or more details might improve the situation but I am not
> sure we want to add more branching here. Can we write something
> similar to HOSTNAME_LOOKUP_DETAIL for hints? Also, I think what you
> are proposing to write is more of a errdetail kind of message. See
> more error routines in the docs [1].
>
Alright, I've updated both sets of error messages to use something like
HOSTNAME_LOOKUP_DETAIL, both for the error message itself, and for the
extra detail message about the replication keyword. Since now we specify
both an errdetail (sent to the client) and an errdetail_log (sent to the
log), I renamed HOSTNAME_LOOKUP_DETAIL to HOSTNAME_LOOKUP_DETAIL_LOG.
- Paul
| Attachment | Content-Type | Size |
|---|---|---|
| pg_hba_conf_error_message_patch_v01.diff | application/octet-stream | 5.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-02-01 20:23:48 | Re: Should we make Bitmapsets a kind of Node? |
| Previous Message | Tom Lane | 2021-02-01 20:03:51 | Re: Recording foreign key relationships for the system catalogs |