| From: | Paul Ramsey <pramsey(at)cleverelephant(dot)ca> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: [PATCH] postgres_fdw extension support |
| Date: | 2015-10-06 14:01:53 |
| Message-ID: | CACowWR0g1+i+MGtVaR1pySZKbuA-fKsvA6uQTa=SVs7sL2SCqw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 6, 2015 at 6:55 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2015-10-06 06:42:17 -0700, Paul Ramsey wrote:
>> *sigh*, no you’re not missing anything. In moving to the cache and
>> marking things just as “shippable” I’ve lost the test that ensures
>> they are shippable for this *particular* server (which only happens in
>> the lookup stage). So yeah, the cache will be wrong in cases where
>> different servers have different extension opti ons.
>
> Should be easy enough to fix - just add the server's oid to the key.
>
> But I guess you're already on that.
Yep, just a big chastened :)
Thanks for the catch, here's the patch,
P
| Attachment | Content-Type | Size |
|---|---|---|
| 20151006a_postgres_fdw_extensions.patch | application/octet-stream | 24.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | YUriy Zhuravlev | 2015-10-06 14:31:40 | Re: No Issue Tracker - Say it Ain't So! |
| Previous Message | Andres Freund | 2015-10-06 13:55:26 | Re: [PATCH] postgres_fdw extension support |