Re: [PATCH] Add EXPLAIN (ALL) shorthand

From: Pete Hollobon <hollobon(at)gmail(dot)com>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org>, Евгений Шишкин <itparanoia(at)gmail(dot)com>, David Christensen <david(at)endpoint(dot)com>, Euler Taveira <euler(at)timbira(dot)com(dot)br>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>
Subject: Re: [PATCH] Add EXPLAIN (ALL) shorthand
Date: 2016-05-21 18:01:14
Message-ID: CACojYcG3W6iSjjy+ZM-5TV5kfQaBDTP5CgerVK0uY-1tktJuew@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 21 May 2016 16:07, "David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
wrote:
> ​And most of the time the choice of options is totally arbitrary based
upon the mood and experience of the user, so what's it matter if they saved
a few keystrokes and set the GUC in the .psqlrc​ file?
>
>> I'm predicting users that will have
>> trouble while using EXPLAIN if someone change the suggested GUC. It also
>> breaks clients/applications that parse EXPLAIN.
>
>
> ​Pretty much the same argument as above.​
>
> I would not expect a DBA to set this value globally - but shame on them
if they do. I'd expect either ALTER ROLE or SET usage, in .psqlrc if
applicable, to be the dominate usage for setting the value to a non-empty
string. There is UI to consider here but I don't see any fundamental
problems.

A GUC seems like overkill for psql. I have the following in my .psqlrc:

\set expall 'EXPLAIN (analyze, buffers, costs, timing, verbose) '

That lets you type

:expall select a, b from whatever;

For GUI tools like pgadmin you've often got built in explain tools anyway.

> David J.
>

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Rushabh Lathia 2016-05-21 18:26:14 Re: Error during restore - dump taken with pg_dumpall -c option
Previous Message Michael Paquier 2016-05-21 17:13:07 Re: Parallel safety tagging of extension functions