| From: | Kevin Grittner <kgrittn(at)gmail(dot)com> |
|---|---|
| To: | emre(at)hasegeli(dot)com |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andreas Karlsson <andreas(at)proxel(dot)se>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com>, Kevin Grittner <kgrittn(at)ymail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Joe Conway <mail(at)joeconway(dot)com> |
| Subject: | Re: Floating point comparison inconsistencies of the geometric types |
| Date: | 2016-09-27 17:35:49 |
| Message-ID: | CACjxUsPaS5kDEwrmLpW+PujQ9kUL+Z0whwPBFQdZRmhag9pmaQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 9, 2016 at 4:25 PM, Kevin Grittner <kgrittn(at)gmail(dot)com> wrote:
> On Sun, Sep 4, 2016 at 12:42 PM, Emre Hasegeli <emre(at)hasegeli(dot)com> wrote:
> These patches apply and build on top of 5c609a74 with no problems,
> but `make check` finds differences per the attached. Please
> investigate why the regression tests are failing and what the
> appropriate response is.
>> I am not much experienced in C. If you think that inline functions
>> are better suited, I can rework the patches.
>
> I suspect that they will be as fast or faster, and they eliminate
> the hazard of multiple evaluation, where a programmer might not be
> aware of the multiple evaluation or of some side-effect of an
> argument.
Emre, are you going to address the above? It would have to be Real
Soon Now.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2016-09-27 18:58:06 | Re: PL/Python adding support for multi-dimensional arrays |
| Previous Message | Vitaly Burovoy | 2016-09-27 17:32:57 | Re: Detect supported SET parameters when pg_restore is run |