From: | Kevin Grittner <kgrittn(at)gmail(dot)com> |
---|---|
To: | Ants Aasma <ants(dot)aasma(at)eesti(dot)ee> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Kevin Grittner <kgrittn(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |
Date: | 2016-04-21 14:16:18 |
Message-ID: | CACjxUsOrCuTT-8AonUrkTo9+1cvFCH7w48zrWGgff8o9=QLThg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Wed, Apr 20, 2016 at 8:08 PM, Ants Aasma <ants(dot)aasma(at)eesti(dot)ee> wrote:
> However, while checking out if my proof of concept patch actually
> works I hit another issue. I couldn't get my test for the feature to
> actually work. The test script I used is attached.
Could you provide enough to make that a self-contained reproducible
test case (i.e., that I don't need to infer or re-write any steps
or guess how to call it)? In previous cases people have given me
where they felt that the feature wasn't working there have have
been valid reasons for it to behave as it was (e.g., a transaction
with a transaction ID and an xmin which prevented cleanup from
advancing). I'll be happy to look at your case and see whether
it's another such case or some bug, but it seems a waste to reverse
engineer or rewrite parts of the test case to do so.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-04-21 14:52:32 | pgsql: Allow queries submitted by postgres_fdw to be canceled. |
Previous Message | Kevin Grittner | 2016-04-21 13:47:58 | pgsql: Inline initial comparisons in TestForOldSnapshot() |
From | Date | Subject | |
---|---|---|---|
Next Message | Andreas Karlsson | 2016-04-21 14:21:24 | Re: Wire protocol compression |
Previous Message | Tom Lane | 2016-04-21 14:07:28 | Re: Wire protocol compression |