Re: Redesigning parallel dump/restore's wait-for-workers logic

From: Kevin Grittner <kgrittn(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Redesigning parallel dump/restore's wait-for-workers logic
Date: 2016-09-27 14:55:18
Message-ID: CACjxUsNiB1LxfF9f4e6egjKhgpb7+7GjPxZiDapM=x6+Y41DwA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

This patch applies with a few minor offsets, compiles without
warning, and passes all regression tests including `make
check-world` with TAP tests enabled. This and the related patch
dealing with the parallel API definitely make things cleaner and
easier to follow.

I find it disappointing that ACLs continue to be held back as a
fourth step outside the framework of the "normal" ordering. That
is an ugly hack, which makes it impossible to, for example, create
a fifth step to create indexes on materialized views and refresh
them in anything resembling a clean fashion. Would it make sense
to deal with the ACL ordering hack in one of these patches, or
should that be left for later?

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2016-09-27 14:55:55 Re: Password identifiers, protocol aging and SCRAM protocol
Previous Message Stas Kelvich 2016-09-27 14:45:59 assert violation in logical messages serialization