| From: | Kevin Grittner <kgrittn(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Ants Aasma <ants(dot)aasma(at)eesti(dot)ee>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Kevin Grittner <kgrittn(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |
| Date: | 2016-05-24 21:51:50 |
| Message-ID: | CACjxUsM4u2AyGU1Qn7WKR2Oen_foCeNY0aBxjKmSM6rf14YBcA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Tue, May 24, 2016 at 4:09 PM, Kevin Grittner <kgrittn(at)gmail(dot)com> wrote:
> On Tue, May 24, 2016 at 3:54 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> It appears that concurrent index builds are currently broken
>> from a quick skim?
>
> Either you don't understand this feature very well, or I don't
> understand concurrent index build very well.
And it may be the latter. On closer review I think some adjustment
may be needed in IndexBuildHeapRangeScan(). I'm not sure that
throwing the error is necessary, since there is a flag to say that
the index is unsafe for existing snapshots -- it may be enough to
set that flag.
Sorry for my earlier email.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-05-24 21:56:16 | Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |
| Previous Message | Kevin Grittner | 2016-05-24 21:19:19 | Re: [HACKERS] Re: pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-05-24 21:56:16 | Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold < |
| Previous Message | Tom Lane | 2016-05-24 21:49:55 | Re: To-Do item: skip table scan for adding column with provable check constraints |