Re: BUG #17731: Server doesn't start after abnormal shutdown while creating unlogged tables

вт, 25 апр. 2023 г. в 06:33, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>:
> The init-fork related code has some other issues with crash-restart. A
> minor one is that the crash of the creating transaction for a unlogged
> relation leaves orphan init fork files. I haven't fully chased the
> specific issue rased here, but I think the common cause in the cases
> is that the file operations around unlogged files are not fully
> transactional. There is a proposed patchset [1], the first patch of
> which makes storage file creation and deletion transactional and
> crash-safe. As far as I see it seems to fix this case, too.

I tried v28 of your patch and it fixes the problem. It seems to me that you are
right, there are other issues with file creation and deletion, and your patch
is a more proper way to fix them.

Best regards,
Karina Litskevich
Postgres Professional: http://postgrespro.com/