| From: | Karina Litskevich <litskevichkarina(at)gmail(dot)com> |
|---|---|
| To: | Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> |
| Cc: | marko(at)joh(dot)to, Alexander Lakhin <exclusion(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Avoid unused value (src/fe_utils/print.c) |
| Date: | 2023-07-21 12:13:02 |
| Message-ID: | CACiT8ib5SY_He-QCwMNg5rGZ4N46sEV_TKk_Qmjg50sDQWGXCA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 12, 2023 at 1:46 AM Ranier Vilela <ranier(dot)vf(at)gmail(dot)com> wrote:
> As there is consensus to keep the no-op assignment,
> I will go ahead and reject the patch.
>
In your patch you suggest removing two assignments, and we only have
consensus to keep one of them. The other one is an obvious no-op.
I attached a patch that removes only one assignment. Could you please try
it and check whether Coverity is still complaining about need_recordsep
variable?
Best regards,
Karina Litskevich
Postgres Professional: http://postgrespro.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Avoid-unused-value-in-print.patch | text/x-patch | 749 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2023-07-21 12:51:31 | Re: postgres_fdw: wrong results with self join + enable_nestloop off |
| Previous Message | Tomas Vondra | 2023-07-21 11:52:55 | Re: Use of additional index columns in rows filtering |