Re: Proposal: recent access based routing for primary-replica setups

Hi Tatsuo,

Sorry again, this was due to the separation of 2 patches and i only sent
the one.

I've merged it into 1 commit and 1 patch and rebased over master to avoid
these issues moving forward.

PFA latest version

On Thu, Nov 20, 2025 at 1:09 AM Tatsuo Ishii <ishii(at)postgresql(dot)org> wrote:

> Hi Nadav,
>
> Thank you for new patch.
> Unfortunately the patch did not apply to current master.
>
> $ git apply
> ~/0001-Fix-multiple-issues-in-external-replication-delay-fe.patch
> error: patch failed: src/streaming_replication/pool_worker_child.c:694
> error: src/streaming_replication/pool_worker_child.c: patch does not apply
>
> Maybe the patch is on top of your previous patch?
>
> Also I suggest to use "-v" option of "git format-patch" to add the
> patch version number so that we can easily know which patch is the
> latest.
>
> Best regards,
> --
> Tatsuo Ishii
> SRA OSS K.K.
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp
>
> > Hi Tatsuo,
> >
> > Please see attached an updated version.
> >
> > thank you
> >
> > On Fri, Nov 7, 2025 at 2:07 AM Tatsuo Ishii <ishii(at)postgresql(dot)org>
> wrote:
> >
> >> > Sorry for that - thanks for the patch.
> >> >
> >> > Please find attached a new version
> >>
> >> Thanks for the new version. Unfortunately this time regression test
> >> fails at:
> >>
> >> > Waiting for command timeout...
> >> > fail: command timeout not detected
> >>
> >> Attached is the pgpool.log.
> >>
> >> Best regards,
> >> --
> >> Tatsuo Ishii
> >> SRA OSS K.K.
> >> English: http://www.sraoss.co.jp/index_en/
> >> Japanese:http://www.sraoss.co.jp
> >>
> >> > On Mon, Nov 3, 2025 at 9:05 AM Tatsuo Ishii <ishii(at)postgresql(dot)org>
> >> wrote:
> >> >
> >> >> > thanks and sorry for the issues, please find attached updated
> version.
> >> >>
> >> >> No problem.
> >> >>
> >> >> This time the patch applies fine, no compiler warnings. However,
> >> >> regression test did not passed here (on Ubuntu 24 LTS if this
> >> >> matters). So I looked into
> >> >> src/test/regression/tests/041.external_replication_delay/test.sh a
> >> >> little bit and apply attached patch (test.sh.patch). It moved forward
> >> >> partially but failed at:
> >> >>
> >> >> fail: command execution failure not detected
> >> >>
> >> >> Please find attached
> >> >>
> >>
> src/test/regression/tests/041.external_replication_delay/testdir/pgpool.log
> >> >> and src/test/regression/log/041.external_replication_delay.
> >> >>
> >> >> Best regards,
> >> >> --
> >> >> Tatsuo Ishii
> >> >> SRA OSS K.K.
> >> >> English: http://www.sraoss.co.jp/index_en/
> >> >> Japanese:http://www.sraoss.co.jp
> >> >>
> >> >
> >> >
> >> > --
> >> > Nadav Shatz
> >> > Tailor Brands | CTO
> >>
> >
> >
> > --
> > Nadav Shatz
> > Tailor Brands | CTO
>

--
Nadav Shatz
Tailor Brands | CTO