| From: | 신성준 <shinsj4653(at)gmail(dot)com> |
|---|---|
| To: | Nikolay Samokhvalov <nik(at)postgres(dot)ai>, assam258(at)gmail(dot)com |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, x4mmm(at)yandex-team(dot)ru, wolakk(at)gmail(dot)com, andreas(at)proxel(dot)se, jakub(dot)wartak(at)enterprisedb(dot)com, horikyota(dot)ntt(at)gmail(dot)com, jian(dot)universality(at)gmail(dot)com |
| Subject: | Re: Add wait events for server logging destination writes |
| Date: | 2026-11-08 04:27:49 |
| Message-ID: | CACdN0M7f4d24Loma6o2PUj1BQx6s1LpOnsp6+LnPjhSc4D-akg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Henson, Nik,
> This is not a blocker. If you prefer the function form, it is fine
> as it is.
Thanks for reading the _nested helpers, Henson. I'd like to keep the
function form in this patch. The macro version would touch about 100
start/end pairs in 45 files plus the LWLock wrappers and errfinish(),
and it changes what end() does for every caller, extensions included.
I think that belongs in its own thread, and I'm happy to try it there
once this one is in.
> From the tester's side I consider v9 ready.
Thanks for the rerun, Nik, and for running v8 next to it as a control.
With both of your reviews in, I've moved the CF entry to Ready for
Committer.
v9 still applies cleanly to current master, so no new version.
Thanks,
Seongjun
| From | Date | Subject | |
|---|---|---|---|
| Next Message | surya poondla | 2026-11-08 04:37:54 | Re: extension_control_path: ignore empty elements and deduplicate directories |
| Previous Message | Xuneng Zhou | 2026-11-08 04:03:25 | Re: aio tests failing on newer Linux kernels |