Re: Add wait events for server logging destination writes

From: 신성준 <shinsj4653(at)gmail(dot)com>
To: Nikolay Samokhvalov <nik(at)postgres(dot)ai>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Kirk Wolak <wolakk(at)gmail(dot)com>, Andreas Karlsson <andreas(at)proxel(dot)se>, assam258(at)gmail(dot)com, Jakub Wartak <jakub(dot)wartak(at)enterprisedb(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, jian(dot)universality(at)gmail(dot)com
Cc: pgsql-hackers mailing list <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add wait events for server logging destination writes
Date: 2026-10-29 05:00:29
Message-ID: CACdN0M6QfkDmMYXQ5as4+dnZEg8tBExEAcedz8dEhH7vomX4aA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

With the November CF about to start, a short status update.

v9 (upthread, Sep 15) still applies cleanly: I rebased it onto
current master today with no conflicts, so I'm not posting a new
version. cfbot is green too.

v9 keeps an outer wait event across a log write by using
pgstat_report_wait_start_nested() / pgstat_report_wait_end_nested()
at the new logging sites. That was the open point from Nik's last
review. The Windows run in my follow-up mail covers the eventlog
path.

What would help most now:

- Nik, a rerun of your harness against v9 when you have a free
moment. No hurry.
- Jakub and Henson, a quick look at the two _nested helpers in
wait_event.h, since v9 is the first version that touches that
file.

If that all looks fine, it would be great if one of you could move
the entry back to Ready for Committer.

Thanks,
Seongjun

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2026-10-29 05:05:55 Re: [PG19] Three bugs with a CHECK constraint that only the child enforces
Previous Message Kirill Reshke 2026-10-29 04:57:51 Re: [PG19] pg_upgrade --check passes, then the upgrade fails