| From: | Önder Kalacı <onderkalaci(at)gmail(dot)com> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18467: postgres_fdw (deparser) ignores LimitOption |
| Date: | 2024-05-23 06:54:31 |
| Message-ID: | CACawEhVY-fU8124qwLU=RpwpKBdBG9sc99kQfeoHPJBZKp+-oQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Hi Japin,
Thanks, the patch looks good to me.
However, as a non-native English speaker, it might not be accurate.
> Feel free to modify it.
>
>
I'm also not good at wording, but I have a minor suggestions like the
following :
/*
* Also, the FETCH FIRST/NEXT ... ROW/ROWS WITH TIES clause cannot be
pushed down
* because:
* a) The remote system may have a different understanding of equality,
which can
* result in varying results, such as non-deterministic collations.
* b) We do not have knowledge of the remote server's version
* as this clause is only supported for PG13 and above.
*/
Thanks,
Onder
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2024-05-23 07:21:10 | Re: Bug report - pg_upgrade tool seems to have a race condition when trying to delete a pg_wal file |
| Previous Message | Michael Paquier | 2024-05-23 06:21:02 | Re: BUG #18362: unaccent rules and Old Greek text |