| From: | Önder Kalacı <onderkalaci(at)gmail(dot)com> |
|---|---|
| To: | "osumi(dot)takamichi(at)fujitsu(dot)com" <osumi(dot)takamichi(at)fujitsu(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher |
| Date: | 2022-08-12 15:11:55 |
| Message-ID: | CACawEhVFScb4uTi-b3vXb=0o6nQMJ8emLYG2LaLUH43gC2c0yw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
>
> FYI, I noticed that v5 causes cfbot failure in [1].
> Could you please fix it in the next version ?
>
Thanks for letting me know!
>
> [19:44:38.420] execReplication.c: In function
> ‘RelationFindReplTupleByIndex’:
> [19:44:38.420] execReplication.c:186:24: error: ‘eq’ may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
> [19:44:38.420] 186 | if (!indisunique && !tuples_equal(outslot,
> searchslot, eq))
> [19:44:38.420] |
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> [19:44:38.420] cc1: all warnings being treated as errors
>
>
It is kind of interesting that the compiler cannot understand that `eq` is
only used when *!indisunique. *Anyway, now I've sent v6 where I avoid the
warning with a slight refactor to avoid the compile warning.
Thanks,
Onder KALACI
| Attachment | Content-Type | Size |
|---|---|---|
| v6_0001_use_index_on_subs_when_pub_rep_ident_full.patch | application/octet-stream | 60.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2022-08-12 16:08:00 | Re: tests and meson - test names and file locations |
| Previous Message | Zhang Mingli | 2022-08-12 15:05:06 | [patch]HashJoin crash |